search

myroslavarm / Experimental-Completion

My internship project: improving code completion for Pharo
6 stars 3 forks source link

CompletionProducerVisitor is not needed #83

Closed MarcusDenker closed 4 years ago

MarcusDenker commented 4 years ago

it is not really a visitor (no state, no visiting, we just call one method).

-> add instead methods as extensions in the AST nodes "completionEntries". In RBProgramNode it returns and empty collection, subclasses have the implementation that are now the visit* methods

MarcusDenker commented 4 years ago

Here is how this would look like: https://github.com/pharo-project/pharo/pull/5038