search

myroslavarm / Experimental-Completion

My internship project: improving code completion for Pharo
6 stars 3 forks source link

incorrect parsing of Error Node #89

Open myroslavarm opened 4 years ago

myroslavarm commented 4 years ago

the code in the issue #78 invoked a DNU on assignment node, when in fact it should've been parsed as a message send. we need to figure out a way how to correctly parse error nodes

myroslavarm commented 4 years ago

another issue with this problem is #75

myroslavarm commented 4 years ago

potential solutions that need to be explored are described in #73

MarcusDenker commented 4 years ago

What we need to do:

-> all these cases we end up calling #completionEntries and #completionToken on the node, which en d up calling the methods in RBProgramNode doing nothing -> completionToken should return the word from courser back to the first non-alphabetic character -> completionEntries should use this string and present all variable names / all message selectors as possible completion

This way we have a good fall back when we end up in situations like this

MarcusDenker commented 4 years ago

Fallback takes care of this now