search

mysensors / NodeManager

Plugin for a rapid development of battery-powered sensors
130 stars 82 forks source link

Fix SSD1306 #519

Open matikij opened 4 years ago

matikij commented 4 years ago

This simple fix works for me.

user2684 commented 4 years ago

Hi, just to double check, is this related to which issue? Is #511 (merged into development recently) still not enough? Thanks!

matikij commented 4 years ago

Hi, I didn't create an issue for this. It was a compile error when I was compiling for ESP8266 - then the ifdef in https://github.com/mysensors/NodeManager/blob/7fbf28aaa42d2e33736f329f152a34e91a217c3c/sensors/DisplaySSD1306.h#L136 does not hold and https://github.com/mysensors/NodeManager/blob/7fbf28aaa42d2e33736f329f152a34e91a217c3c/sensors/DisplaySSD1306.h#L139 is included, so that means that _oled field is of type SSD1306AsciiWire, which is not a SSD1306AsciiAvrI2c as expected by getDisplay() signature. SSD1306Ascii is a common and direct ancestor of both classes.

user2684 commented 4 years ago

Oh understand, thanks for the clarification!