search

mysensors / NodeManager

Plugin for a rapid development of battery-powered sensors
130 stars 82 forks source link

SensorMQ debug issues #543

Closed j54n1n closed 2 years ago

j54n1n commented 2 years ago

Hello there,

In search for the cause of the floating point issue #542 I found that also this sensor has some issues with its debug print.

First at the calibration stage there is a missing new line:

4658 NM:SENS:MQ:CAL5112 TSF:MSG:READ,0-0-84,s=255,c=3,t=6,pt=0,l=1,sg=0:M

Then afterwards there is a shift of the parameters in the debug print like so:

29839 NM:SENS:MQ:CAL OK Rs=7905 Ro=18779 Rl=_rl F=0.1000 x^=0.38

Note the _rl that does not get replaced by a value.

Second the log line with:

30225 NM:SENS:MQ(204):READ Rs=-2470 Rs/Ro=17747.00 ppm=18

has a similar issue with printing floating point numbers as the mentioned issue above.

I will try to fix this in a pull request shortly.

Kind regards.

user2684 commented 2 years ago

Thanks also for this contribution, merging it into development branch