SensorInterrupt onLoop routine sends value

mysensors / NodeManager

Plugin for a rapid development of battery-powered sensors

130 stars 82 forks source link

SensorInterrupt onLoop routine sends value #549

Open janjurca opened 2 years ago

janjurca commented 2 years ago

Hello I've made change that is maybe worth of discussion. The actual SensorInterrupt does send it's value only when the interrupt happens. But when the transmission fails for some reason then the value is not propagated to server not even on report interval.

So I've added the onLoop() method to SensorInterrupt.h.

user2684 commented 2 years ago

Hi! A few comments:

What if the transmission was successful, is a second transmission taking place anyway?
Any risk for non-sleeping node that loop is executed continuously?
Ensure the PR is against development branch not master Thanks!