Fix mecab-python3 version

myshell-ai / MeloTTS

High-quality multi-lingual text-to-speech library by MyShell.ai. Support English, Spanish, French, Chinese, Japanese and Korean.

MIT License

4.87k stars 636 forks source link

Fix mecab-python3 version #159

Open polm opened 4 months ago

polm commented 4 months ago

Hello, I am the maintainer of mecab-python3. Users of your library have been opening issues at my repo because they have trouble building MeCab. They should not have to build MeCab, but MeloTTS is using an old version of mecab-python3 that doesn't support recent Python versions. This raises the version. There are no functionality changes.

polm commented 4 months ago

This also removes the double entry noted in #150.

prateeksachan commented 4 months ago

One of our repo is also receiving issues related to this. thanks @polm for providing the patch. ref: https://github.com/bolna-ai/bolna/issues/305

polm commented 4 months ago

Also see #51 - mecab-python3 should be optional in this library, since not everyone is using Japanese.