so the type name and the value doesn't match, after i asked on the #hexabus channel
if this is intended ` sad that this is a typo, and that 66BYTES needs to be renamed 65BYTES since that payload is used from the statemachine upload, which is 65 Bytes.
So that means HXB_DTYPE_66BYTES needs also to be renamed to HXB_DTYPE_65BYtes.
While i am ad it, why is this called MAX_BUFFER_LENGTH when a 66Byte payload needs always to be 65 bytes long and can't be 64 bytes in length.
I know that are just internals but that is confusing, since MAX_BUFFER_LENGTH indicates that that buffer can be smaller. Same for 16Bytes and String.
morriswinkler
commented
10 years ago
Cheers mate,
i just figured in shared/hexabus_definitions.h
so the type name and the value doesn't match, after i asked on the #hexabus channel if this is intended ` sad that this is a typo, and that 66BYTES needs to be renamed 65BYTES since that payload is used from the statemachine upload, which is 65 Bytes.
So that means HXB_DTYPE_66BYTES needs also to be renamed to HXB_DTYPE_65BYtes.
While i am ad it, why is this called MAX_BUFFER_LENGTH when a 66Byte payload needs always to be 65 bytes long and can't be 64 bytes in length.
I know that are just internals but that is confusing, since MAX_BUFFER_LENGTH indicates that that buffer can be smaller. Same for 16Bytes and String.