search

mysociety / alaveteli

Provide a Freedom of Information request system for your jurisdiction
https://alaveteli.org
Other
389 stars 195 forks source link

Is "We don’t want to vendor Rails" step in the Mac OS X install documentation necessary? #2200

Closed equivalentideas closed 9 years ago

equivalentideas commented 9 years ago

Is this step still necessary?

Clone Alaveteli

We don’t want to vendor Rails, as it causes problems locally.

git clone https://github.com/mysociety/alaveteli.git cd alaveteli git submodule init

sed -i~ 's/\[submodule "vendor\/rails"\]//' .git/config

sed -i~ 's/url = git:\/\/github.com\/rails\/rails.git//' .git/config git submodule update

Note: Due to Markdown bugs, the first sed command above does not display properly if it appears in blockquote.

If not, it could be an opportunity to cut a step.

crowbot commented 9 years ago

Hi @equivalentideas, thanks for reporting this, I've made a pull request to remove the vendored rails bit as it is indeed obsolete. In general, the OSX installation documentation is fairly old and skeletal. We do have quite good instructions for installing on a dev machine using vagrant though. Are you trying to set up a dev box? If so, let us know if there's anything we can do to help.

equivalentideas commented 9 years ago

Thanks for that @crowbot . I initially skipped this step entirely as I thought it was out of date, and then had to come back later and do the submodules stuff.

I've set up a dev version on my laptop without vagrant now. I'm working on implementing the responsive styles for the Right To Know theme :)

crowbot commented 9 years ago

Ah, great!

garethrees commented 9 years ago

Fixed by https://github.com/mysociety/alaveteli/pull/2204