mysociety / alaveteli

Provide a Freedom of Information request system for your jurisdiction
https://alaveteli.org
Other
387 stars 195 forks source link

add a settings variable for background colour (refactor only) #2376

Open equivalentideas opened 9 years ago

equivalentideas commented 9 years ago

The background colour of the site seems to be a common thing to change in an alaveteli theme, see:

https://www.righttoknow.org.au/ https://sobanukirwa.rw/ https://www.whatdotheyknow.com/ http://www.infoprovsechny.cz/

Adding a variable in _settings.scss would mean one small thing less to override in _custom.scss and would make things a little clearer. Just a small thing I came across.

crowbot commented 9 years ago

Is your idea that themes would then override _settings.scss as well as _custom.scss or would they set the variable for their site some other way?

equivalentideas commented 9 years ago

The way we're doing it in Right To Know is overriding with our own _settings.scss and then also naming some new variables in _custom.scss.

I think overriding the _settings.scss where possible is nice because:

crowbot commented 9 years ago

OK, makes sense.