search

mysociety / alaveteli

Provide a Freedom of Information request system for your jurisdiction
https://alaveteli.org
Other
389 stars 195 forks source link

Routing error for RSS search feed #3517

Closed lizconlan closed 7 years ago

lizconlan commented 8 years ago

This form of route for the search RSS feeds are treated as invalid:

/feed/search/bob%202007/10/13..2007/11/13 /track/search/bob%202007/10/13..2007/11/13

...and result in an ApplicationController::RouteNotFound error.

To replicate in the browser using the sample data (suggest not in Safari as its RSS handling is confusing)...

  1. Search for 'bob'
  2. Change 'Showing' to 'requests'
  3. Set the Date filter to 2007/10/13 to 2007/11/13
  4. Press 'Filter'
  5. Click 'RSS feed'

(Appears to affect develop but not hotfix/0.25.0.9)

lizconlan commented 8 years ago

I suspect this may be related to #3362

lizconlan commented 8 years ago

/feed/search/bob%20(variety:sent%20OR%20variety:followup_sent%20OR%20variety:response%20OR%20variety:comment)%20(latest_status:waiting_response%20OR%20latest_status:waiting_clarification%20OR%20waiting_classification:true%20OR%20latest_status:internal_review%20OR%20latest_status:gone_postal%20OR%20latest_status:error_message%20OR%20latest_status:requires_admin)

works just fine so it seems to be something specific to the date filter which is tripping it.

Manually changing the date format to '2007-10-13..2007-11-13' makes no difference

lizconlan commented 7 years ago

Appears to have been broken by the removal of the constraints option from the routes file in eef48cb (lazily reinstating it breaks JSON search handling instead)