Add important_notes tag to bodies that need notes shown in pro batch mode

[garethrees]

We added the ability to show authority notes in the batch interface in https://github.com/mysociety/alaveteli-professional/issues/356.

For the notes to display, the authority needs the important_notes tag applied.

My default course of action was to apply that to the top 20 authorities that have notes, sorted by most requests.

@RichardTaylor any thoughts on this?

[RichardTaylor]

It might be useful for batch interface users to be alerted when there are foi_no bodies in their batch, that could be achieved via a dedicated alert or by reviewing those bodies tagged foi_no and adding an important_notes tag where it's considered appropriate. Current example : https://www.whatdotheyknow.com/body/npcc (Similar applies to eir_only)

Important notes for public users would include those on the Home Office and DVLA pages urging users not to use the service for personal correspondence. Hopefully batch pro users won't need such warnings.

The BBC is a bit of a special case and should probably be tagged important_notes - it's got quite a long note though.

Another situation batch requestors might want to be alerted to is where we list a number of bodies with the same contact address; eg. on WhatDoTheyKnow at the moment we list 11 bodies using the Ministry of Justice FOI address and 32 using the MoD contact address. We've decided it's appropriate to enable users to address requests to each body separately and in many cases they are distinctly subject to the act, so this might not be an issue for us - the MoD shouldn't really be surprised to get a three copies of the same request addressed in turn to the Army, Navy and Air Force for example. (The armed forces are each subject to the Act, as is the MoD)

It might be useful to note what the notes field is used for, uses include:

• A description of the body, which might help people find it.
• Listing subunits of a body, and wholly owned subsidiaries (which we may or may not list separately).
• Adding other names a body uses or is known by.
• An address, particularly in the case of schools or dentists, to help disambiguation with similarly named bodies.
• Information specifically relating to the body's status in respect of access to information laws

I commented at https://github.com/mysociety/alaveteli-professional/issues/356#issuecomment-361589907 saying:

The actual plain English advice we give people who write to us before making lots of requests via WhatDoTheyKnow at the moment tends to be along the lines of, for example:

You're about to make a request to Police and Crime Commissioners, please take care to check your request wouldn't be better addressed to the relevant police forces.

You're about to make a request to local councils, please do your best to select councils which are responsible for the matters which you are asking about.

Some of the bodies you are about to make a request to are not formally subject to Freedom of Information law; they might well be subject to other access to information laws though. This is something you might want to consider when writing, and following up, your request.

See also #387

[garethrees]

I've added important_notes to Home Office, DVLA and BBC.

We're not going to show defunct or no_foi authorities in the category selection tool, but it does look like we show them in "search" mode at the moment.

[garethrees]

Noting here that the styles need tweaking:

[garethrees]

sanitize the contents

[garethrees]

I've added important_notes to the top 20 authorities (by request volume) that have notes:

PublicBody.joins(:translations).where("public_body_translations.notes IS NOT NULL AND public_body_translations.locale = 'en'").order('public_bodies.info_requests_count DESC').limit(20).each { |b| b.add_tag_if_not_already_present('important_notes') }

Any more can be added on a case-by-case basis