search

mysociety / alaveteli

Provide a Freedom of Information request system for your jurisdiction
https://alaveteli.org
Other
387 stars 195 forks source link

Event not logged when hiding comment #5596

Open gbp opened 4 years ago

gbp commented 4 years ago

On the admin/users#show page, using the checkboxes to hide/show selected annotations/comments doesn't save an InfoRequestEvent as such there is no record of when the comment visibility changed.

garethrees commented 4 years ago

This also means that the event doesn't get reindexed, so is still visible in places where we show it via the search results.

crowbot commented 3 years ago

Just ran across this again, causing comments that have been hidden on the requests themselves to be linked to from the user's profile page

garethrees commented 2 years ago

This also means that the event doesn't get reindexed, so is still visible in places where we show it via the search results.

This portion of the issue was ticketed in https://github.com/mysociety/alaveteli/issues/6669 and fixed by 40b291c4ea5919176ab6ad02faefad8901b0a090. (Edit 2024: better to look at the full PR to understand the whole fix; we added an after save callback to reindex: https://github.com/mysociety/alaveteli/pull/6670)

garethrees commented 2 years ago

Just noting https://github.com/mysociety/alaveteli/pull/6804 in relation to this.