Add images to body notes

mysociety / alaveteli

Provide a Freedom of Information request system for your jurisdiction

https://alaveteli.org

Other

387 stars 195 forks source link

Add images to body notes #7160

Open RichardTaylor opened 2 years ago

RichardTaylor commented 2 years ago

See example in the screenshot.

garethrees commented 2 years ago

Some comments summarised from https://github.com/mysociety/alaveteli/issues/6586:

Pages without the images look dull in comparison
Marginally more preference towards the banner style, but general approval of both
There could be performance implications (though this can be mitigated by resizing & compressing on upload)
Current positioning pushes make a request CTA and request archive further down the page. That's not to say this isn't worth doing, but it is a thing to consider.

I've renamed this to be about images rather than logos, since the latter is covered in https://github.com/mysociety/alaveteli/issues/6172 and I think has some slightly different concerns.

mdeuk commented 2 years ago

* There could be performance implications (though this can be mitigated by resizing & compressing on upload)

Noting the moment of travel on #1155 - would ActiveStorage variants help us here?

FOIMonkey commented 2 years ago

Sadly, they don't look great on the pro request form: 2022-07-15

RichardTaylor commented 2 years ago

Sadly, they don't look great on the pro request form:

I didn't see a problem with them appearing on the request forms. It does trigger the display of the notes field when there are no text based notes though. Having the "About" title with text is not ideal.

RichardTaylor commented 2 years ago

changed the title System for allowing users, and public bodies, to suggest, and upload, images and logos for use on body pages Add images and logos to body pages

I thought as we already had tickets for general images and logos for body pages we could have a new one (this one) for a system for users, including public body users, to submit/suggest such images. That was my intention with this ticket. Such a ticket for submission of images could be started again given the direction this ticket has taken.

RichardTaylor commented 2 years ago

Such a ticket for submission of images could be started again given the direction this ticket has taken.

Done: https://github.com/mysociety/alaveteli/issues/7165

garethrees commented 2 years ago

Noting the moment of travel on https://github.com/mysociety/alaveteli/issues/1155#issuecomment-963128672- would ActiveStorage variants help us here?

Yep, that's what we'd use.

Sadly, they don't look great on the pro request form:

I didn't see a problem with them appearing on the request forms.

Hmm, yeah, this isn't good. The pro interface is intentionally utilitarian, and this adds extra ornament that ought not to appear.

I thought as we already had tickets for general images…

That's for WDTK, not Alaveteli.

for a system for users, including public body users, to submit/suggest such images

That's an enhancement to this – we don't even have the basic functionality to properly attach images yet, which is a design problem in its own right. Once we've figured out what we want and where to put them, a suggestion workflow can be thought about.

RichardTaylor commented 2 years ago

From @garethrees at https://github.com/mysociety/alaveteli/issues/6586#issuecomment-1184344907

Can do some pretty fancy CSS these days so might be able to make these more of a background banner.

TheyWorkForYou has images behind text at eg.

https://www.theyworkforyou.com/mp/10001/diane_abbott/hackney_north_and_stoke_newington/divisions?policy=1049