search

mysociety / alaveteli

Provide a Freedom of Information request system for your jurisdiction
https://alaveteli.org
Other
389 stars 196 forks source link

Erronous shebang in docker/reset #8244

Closed andersjl closed 4 months ago

andersjl commented 5 months ago

The shebang is #!/bin/sh, but on my Ubuntu 22.04 the script does not run with bash in sh mode.

I see three solutions, which is why I do not make a pull request:

  1. Change the shebang to #!/bin/bash
  2. Change the script so that it runs in sh mode
  3. Change the documentation to do "bash docker/reset" rather than "docker/reset" (and probably remove the shebang).
garethrees commented 4 months ago

Definitely want the script to be executable as docker/reset, so I'd rule out 3 as an option.

I don't have a preference between option 1 and 2. I guess I'd say option 2 if its trivial; option 1 if option 2 would take a significant amount of time or involves downsides that we wouldn't want to accept.

andersjl commented 4 months ago

Ok, I will try 2, then?