search

mysociety / alaveteli

Provide a Freedom of Information request system for your jurisdiction
https://alaveteli.org
Other
389 stars 195 forks source link

HTML issues - /admin/request/show/xxx #905

Closed skenaja closed 11 years ago

skenaja commented 11 years ago

1) Another HTML escaping issue

/admin/request/show/xxxx expand Outgoing message "Body" section shows following rather than clicky link

blah blah<a href="#" class="toggle-hidden">...</a>

2) Same on Incoming message section, "Cached attachment text clipped", "Cached main body text folded", and "Cached main body text unfolded".

3) Events section, "Params yaml" should also probably be rendered as HTML

mlandauer commented 11 years ago

Fix for the events "params yaml" is at 4a05a8182817512cd8908b90959d0e22b98126f1 (currently just on the rails-3-develop branch)

mlandauer commented 11 years ago

I'm not able to reproduce the other escaping issues on the "develop" branch. @skenaja, which version of Alaveteli are you on?

skenaja commented 11 years ago

From https://www.whatdotheyknow.com/admin/debug :-

On 4 April 2013 17:23, Matthew Landauer notifications@github.com wrote:

I'm not able to reproduce the other escaping issues on the "develop" branch. @skenaja, which version of Alaveteli are you on?

— Reply to this email directly or view it on GitHub.

mlandauer commented 11 years ago

I have a suspicion about what might be happening here. @skenaja do you have access to the Alavateli configuration files.

If so, in config/general.yml does the THEME_URLS include the adminbootstraptheme? If it does, it should be removed. Otherwise you won't be seeing the latest and greatest in the admin interface.

dracos commented 11 years ago

THEME_URLS on live whatdotheyknow appears to just be - 'git://github.com/mysociety/whatdotheyknow-theme.git'

mlandauer commented 11 years ago

Matthew, thanks for checking! Okay, it's something else then.

On Fri, Apr 5, 2013 at 11:36 PM, Matthew Somerville < notifications@github.com> wrote:

THEME_URLS on live whatdotheyknow appears to just be - 'git:// github.com/mysociety/whatdotheyknow-theme.git'

— Reply to this email directly or view it on GitHubhttps://github.com/mysociety/alaveteli/issues/905#issuecomment-15953189 .

Dr Matthew Landauer Director, OpenAustralia Foundation

matthew@openaustraliafoundation.org.au

crowbot commented 11 years ago

1) and 2) fixed in e283db7493e8e924a14ba20a8354b5fc4045f92c. I've also cherry-picked 4a05a81 to the develop branch so it'll be deployed in the next release.