Annual report 2022 - Githubissues

lucascumsille commented 1 year ago

Hey @zarino Just in case, It's not ready there are some links that need update + some extra copy from trustees and Louise.

Fixes: https://github.com/mysociety/orgsites/issues/1266 Copy here

Let me know if there is anything I should fix in the meantime =) And I'll rebase before merging, I know there are a lot of commits in there.

Things to check before squash and merge:

[x] Colour contrast passes WCAG 2.1 AA
[x] All images have alt text and loading="lazy"
[x] Links in the "Jump to section" menu are all correct, and all sections on the page are represented and in the correct order
[x] Image credits in the footer are correct, and all images on the page that require credit are represented
[x] All straight quotes have been replaced with curly quotes
[x] Em and En dashes have been used, instead of hyphens, where appropriate
[x] Headings do not end with full stops
[x] Brand names are correctly capitalised – eg: “YouTube”
[x] Consistent capitalisation for headings, buttons, and statistics (almost always sentence case)

lucascumsille commented 1 year ago

Thanks for the feedback @zarino I just pushed some commit fixing the tweaks you ask for. I didn't include the header one, yet.

zarino commented 1 year ago

@MyfanwyNixon what do you think about the two ways that stats are handled, in the Climate and Transparency section:

…vs the TICTeC section:

I think in particular "9 other people’s" just makes no sense to me on first glance. But it’s a bit odd that this is the only place on the page where we have a noun after the number, in the stat headings. Do you think it’d look weird if we treated it the same as the others?…

MyfanwyNixon commented 1 year ago

@zarino yes I agree 'other people's' is odd - and the solution looks better.

zarino commented 1 year ago

@lucascumsille, once you’ve got what you think is all of the content from @MyfanwyNixon’s document into this, it might be worth us somehow sharing it with @MyfanwyNixon to check she’s happy with how some of the content has been re-ordered – eg: the document puts the new/departed staff at the end, but the webpage currently has them in the traditional position at the start.

zarino commented 1 year ago

@lucascumsille I’ve pushed a commit that rearranges the TICTeC facts and figures into three columns.

MyfanwyNixon commented 1 year ago

the document puts the new/departed staff at the end, but the webpage currently has them in the traditional position at the start.

Yeah definitely want them at the end please - this was a conscious decision to make it easier for the reader to jump into the main content.

lucascumsille commented 1 year ago

Thanks for the feedback everyone. I have added some commits that solves the issues above.

@MyfanwyNixon After the addition of the chair and Louise, let me know if you want me to change the background color of the donation section (currently purple) and turn it into the cream that is above and below.

There are still a couple of additions to the copy and after that I will go through Zarino's checklist on the top.

lucascumsille commented 1 year ago

the document puts the new/departed staff at the end, but the webpage currently has them in the traditional position at the start.

Yeah definitely want them at the end please - this was a conscious decision to make it easier for the reader to jump into the main content.

I moved it to the bottom =)

zarino commented 1 year ago

FWIW @sagepe has created a ticket here for deploying this site: https://github.com/mysociety/sysadmin/issues/1738

sagepe commented 1 year ago

Just noting that I think you'll need to add 2022 to the year array in the test matrix in .github/workflows/ci.yml

mysociety / annual-report

Annual report 2022 #69