lucascumsille
commented
1 year ago Sorry @struan I know I had told you that we would follow the same behaviour as the methodology page. But yesterday with @zarino decided to display Single tier by default.
Like /sections/, /sections/
/ doesn’t currently show a table, by default, on pageload. As above, I think this page should behave like the homepage, with the "Single Tier" button pre-selected (or "Combined Authority" if this is a section that only applies to CAs), until the user chooses otherwise.
My thought in order to prevent:
Even worse, when you click that council type button, the entire page reloads and you’re left staring at the top of the new page, while the table of questions is (in my case) at least two full page scrolls down below. Yuck.
It would be to add an ID to the table section, and add that id to the buttons. For example {% url 'scoring:section' section.code %}?type=county/#table-id
For this issue:
When you "select" a council type button under "show questions by type of council" on /sections//, the button doesn’t display as "active".
Is it too much hassle to add a body class like single-tier combined? that way controlling the active effect via CSS would be quite simple. I think we could achieve it with JS, but probably it would have less hassle with Django.
❗️ Tick an item off as soon as you’ve committed the fix to
589-scorecards-bugs👍Social graphics
[x] In the social graphic for an individual council, if a council’s score in a section is 80% or more, it should be given a "high scorer" star and message.
[x] A
section/top_performergraphic should be generated for every council that has scored 80% or more in the section, not just the single highest scoring council in that section.Homepage
[x]
Page<title>still says "Council Climate Plan Scorecards"[x]
SVGs inlined into CSS don‘t work (see #462) – we need to use something else for table sorting icons, radio button icons, accordion-button icons, and the mobile nav hamburger icon:[x]
Radio buttons across the whole site are lackingmargin-leftto prevent them touching their labels[x]
I think CEUK wanted the sections to have different colours (rather than shades of purple/violet)?Section child page
[ ] Can we get the Single Tier questions displayed by default, rather than requiring the user to click one of the council type buttons?
[ ] Council type buttons have no "active" state when they’re selected.
[x] Clicking a council type button reloads the page, and leaves you up at the top of the page. Can we at very least include a hash fragment identifier in the URL, which takes you down to the "Section list of questions" heading? (See @lucascumsille’s suggested URL template below)
[x] Missing page
<title>[x]
Missing vertical margin or padding at end of page content:[x]
Extra margin-bottom on "criteria" modal header:Council page
[x]
Link to See this council’s 2021 Plan Scorecard button[x] Add link to -> You can check out how this council scored in the Plan Scorecards (different questions to the Action Scorecards). Add same link that we use in the breadcrumb to check once this branch has been merge
[x] Add the overall score somewhere in the table. CEUK Recommended at the bottom of the page.
[x] Clear All filter not working
[ ] Council under review message. Need to add conditional to be shown when needed.
[x] Council page autocomplete is not working.
[x]
This council is one of the highest scoring councils in single tier .hero section wording is weird – should probably beThis councils is one of the highest scoring {{ type }} councils.[x]
The same text is repeated under both "Key definitions" headings – "Question Weighting" and "Section Score & Weighting" – mistake?[x]
As on homepage, missing margin-right on checkbox:[x]
Extra margin-bottom between question text and buttons – probably want to either remove the margin-bottom on thep, or remove the margin-top on the firstbutton: