17 home filter styling - Githubissues

mysociety / contract-countdown

https://mysociety.github.io/contract-countdown/

0 stars 0 forks source link

17 home filter styling #22

Closed lucascumsille closed 1 year ago

lucascumsille commented 1 year ago

I have added two layout options for the filter. Let me know which one you prefer. I prefer the second version, which saves some vertical space, aligns the items to the left and doesn't give us the empty spacing below the search bar.

Option 1

Screenshot 2022-09-22 at 12 33 11

Screenshot 2022-09-22 at 12 33 06

Option 2

Screenshot 2022-09-23 at 07 26 52

A few notes:

When I saw the left padding for the search bar, I thought it might be for an icon.
At first, I didn't notice the "Advanced filters" button. I saw it when we were on yesterday's meeting with Alexander, so I thought to make it pop up more, but without giving the same priority as the "Submit" button.

I have also included some minor but unrelated issues to this PR:

I decreased the size of the text for the card title. I noticed they were a bit hard to read when the title was too long, with few characters/words in one line.
I had a contrast issue between the primary colour and the grey background, so I darkened the version a bit.

Preview of the cards titles

Screenshot 2022-09-23 at 07 32 44

They are separate commits, so let me know if you want me to get rid of any.

Fixes #17

lucascumsille commented 1 year ago

@zarino I have added a --fixup that fixes the problem listed above.