search

mysociety / contract-countdown

https://mysociety.github.io/contract-countdown/
0 stars 0 forks source link

Change dockerfile so that it only has 1 stage. #25

Closed alexander-griffen closed 1 year ago

alexander-griffen commented 1 year ago

This just changes the Dockerfile so that the Docker image is built in only one stage.

ajparsons commented 1 year ago

Drive by comments:

Don't think the final COPY is needed - this will be for making it work as a service that contains all the stuff - but because docker-compose maps the working dir to /app anyway it's all made inaccessible.

Speaking of the /app - changing the references to /app to /workspaces/contract-countdown/ in Dockerfile and docker-compose will make it it compatible with codespaces later on. (like https://github.com/mysociety/caps/blob/master/docker-compose.yml#L15)