search

mysociety / derechoapreguntar-theme

The Alaveteli theme for Derecho a Preguntar (Nicaragua)
https://derechoapreguntar.org/
Other
0 stars 3 forks source link

0.25 upgrade #149

Closed lizconlan closed 5 years ago

lizconlan commented 8 years ago

Connects to #148

lizconlan commented 8 years ago

Haven't got the look quite the same - the logo has moved by about 1px and the banner section takes up slightly less room, which... might be good? A second opinion on that would be great!

garethrees commented 8 years ago

Haven't got the look quite the same

Screenshot plz! :)

lizconlan commented 8 years ago

Screenshot plz! :)

Knew I'd forgotten something!

Before (as live)...

screen shot 2016-08-26 at 12 37 29

After...

screen shot 2016-08-26 at 12 52 39

garethrees commented 8 years ago

Footer should have role="contentinfo"

garethrees commented 8 years ago

Looks good on the whole. Couple of missed bits. Have you checked the Ruby overrides? There are quite a few and not sure if any conflict.

lizconlan commented 8 years ago

The overrides don't look too controversial - mostly extra User fields and a custom state for extended deadlines. Oh and hacking in the Public Body categories for es_NI

lizconlan commented 8 years ago

Homepage

nicaragua-screenshot

Authority page

nicaragua-authority

Request page

nicaragua-request

Mobile view

nicaragua-mobile

Mobile menu detail

nicaragua-mobile-menu

garethrees commented 8 years ago

Looks good. Squash it down but we'll have to wait 'til translations are done before merge.

Also need to generate the theme translations, but will do that after merge.