search

mysociety / fixmystreet-mobile

Cordova application for making reports to FixMyStreet
Other
49 stars 48 forks source link

Use OpenStreetMap tiles if not in UK. #223

Closed dracos closed 8 years ago

dracos commented 8 years ago

If the cobrand is not fixmystreet.com, default to OpenStreetMap rather than the Bing/OS hybrid. This fixes the issue of people outside the UK getting a grey map. Fixes #198

davea commented 8 years ago

This seems to solve the same problem as 2b61987addccca46871b23952ce3508610aee7de, except that uses CONFIG.isUK to determine which map to use. I think that approach might be better rather than relying on CONFIG.COBRAND, because if we want to cobrand the app for UK councils we'll have to add more conditions to the CONFIG.COBRAND test.

Apart from that, looks good!

dracos commented 8 years ago

Fair enough; I've added a MAP_TYPE configuration variable, because if we don't want to rely on COBRAND, we probably don't want to rely on an isUK variable either as some UK cobrands already have a different map type.