search

mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
517 stars 241 forks source link

Disassociate category name from asset layers #3413

Open struan opened 3 years ago

struan commented 3 years ago

At the moment the display of asset layers is tied to the category name. This means that if a category name changed then the asset layer code has to be updated. This isn't a problem for integrations where we control the list of categories but in cases where the category list is maintained by the council it's possible for the asset layers to be broken by a change of category name.

Possibly the asset layer code should be tied to something that is fixed.

davea commented 3 years ago

A good first step might be to shift the mapping between layers and category/group names to COBRAND_FEATURES in general.yml which would at least save having to commit/PR a change in the main FMS repo. Would still need to deploy the site each time though.

Longer term it might be nice for a cobrand to be able to declare its available asset layers and for each category in the admin to have a drop-down field to select its associated layer(s).

Each cobrand assets.js has a slightly different way of setting up layers so it might be complicated to find a one-size-fits-all solution though.

dracos commented 2 years ago

Just thinking about this again today; not forgetting .com with all the cobrand asset layers it'd have to work with, somehow, hmm. Would be nice, though.