mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
506 stars 235 forks source link

[Merton] Send updates to Crimson #4948

Closed davea closed 4 months ago

davea commented 4 months ago

https://github.com/mysociety/societyworks/issues/4241

~For some reason the test fails because of the -not => { 'me.extra' => { '\?' => 'sent_to_crimson' } }, in SendWaste::_comments, despite it appearing to work correctly when run manually. Not sure what's going on there but wanted to get this PR opened in any case.~

[skip changelog]

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.64%. Comparing base (2552c12) to head (cb8bdba).

:exclamation: Current head cb8bdba differs from pull request most recent head da619fd. Consider uploading reports for the commit da619fd to get more accurate results

Files Patch % Lines
perllib/FixMyStreet/Script/Merton/SendWaste.pm 90.47% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## merton-ww-initial #4948 +/- ## ================================================== Coverage 82.64% 82.64% ================================================== Files 394 394 Lines 30560 30580 +20 Branches 4820 4821 +1 ================================================== + Hits 25257 25274 +17 - Misses 3864 3865 +1 - Partials 1439 1441 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.