Closed lucascumsille closed 2 months ago
Attention: Patch coverage is 16.66667%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 82.61%. Comparing base (
2281737
) to head (9d31719
).
Files | Patch % | Lines |
---|---|---|
web/cobrands/fixmystreet/fixmystreet.js | 16.66% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @dracos =) It's all working on my end. Regarding the rebase would you prefer to keep the two initial main commits or everything in one?
Two commits is fine, they're making separate independent changes. If anything, you could say the &:has(.form-error) { @include flex-direction(column); }
change could be its own commit, as that's a separate thing again, fixing the display of flex errors not just there but elsewhere.
Fixes: https://github.com/mysociety/societyworks/issues/4212
Both of these fixes should improve how users using assistive devices travel across inputs by modifying which focus element we are focusing, making it easier to rectify errors or previous steps.
List of commits
Added fix to email input focus behaviour when there is an error First commit fixes: SW ref 30: Local RSS feeds and email alerts - part 2
[x] When the Subscribe by email form is submitted with an error, focus should be sent to the "Email address' input element.
[x] SW ref 41: Local RSS feeds and email alerts - part 2 An error message is provided in text, but it is not programmatically associated with the email address input element.
Added fix for focus behaviour in pages with a .form-section-preview SW ref 29: Reported issue - provide an update form - tell us about you (step 2)
[Skip changelog]