mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
506 stars 235 forks source link

Improvements to focus order #4952

Closed lucascumsille closed 2 months ago

lucascumsille commented 4 months ago

Fixes: https://github.com/mysociety/societyworks/issues/4212

Both of these fixes should improve how users using assistive devices travel across inputs by modifying which focus element we are focusing, making it easier to rectify errors or previous steps.

List of commits

Added fix to email input focus behaviour when there is an error First commit fixes: SW ref 30: Local RSS feeds and email alerts - part 2

Added fix for focus behaviour in pages with a .form-section-preview SW ref 29: Reported issue - provide an update form - tell us about you (step 2)

[Skip changelog]

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.61%. Comparing base (2281737) to head (9d31719).

Files Patch % Lines
web/cobrands/fixmystreet/fixmystreet.js 16.66% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4952 +/- ## ========================================== - Coverage 82.62% 82.61% -0.02% ========================================== Files 395 395 Lines 30798 30803 +5 Branches 4884 4884 ========================================== Hits 25448 25448 - Misses 3901 3906 +5 Partials 1449 1449 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lucascumsille commented 2 months ago

Thanks @dracos =) It's all working on my end. Regarding the rebase would you prefer to keep the two initial main commits or everything in one?

dracos commented 2 months ago

Two commits is fine, they're making separate independent changes. If anything, you could say the &:has(.form-error) { @include flex-direction(column); } change could be its own commit, as that's a separate thing again, fixing the display of flex errors not just there but elsewhere.