search

mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
506 stars 235 forks source link

[Merton][WW] Adds configurations for bulky waste #4956

Closed MorayMySoc closed 3 months ago

MorayMySoc commented 4 months ago

Allows report missed collection on the day

https://github.com/mysociety/societyworks/issues/4270

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.69%. Comparing base (a847178) to head (824eb04).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## merton-ww-bulky #4956 +/- ## =================================================== - Coverage 82.69% 82.69% -0.01% =================================================== Files 401 401 Lines 30950 30967 +17 Branches 4887 4890 +3 =================================================== + Hits 25594 25607 +13 - Misses 3899 3904 +5 + Partials 1457 1456 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dracos commented 3 months ago

@MorayMySoc I've taken your idea from https://github.com/mysociety/fixmystreet/pull/4736 and used that instead, as it felt like a nicer way of doing it? I've added a fixup commit - let me know what you think about it. I've already merged the other commits that were in this PR into merton-ww-bulky, thanks.

MorayMySoc commented 3 months ago

@dracos I think this fits better into the flow in the way everything else is working rather than being a different solution to the same problem.