Closed lucascumsille closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.60%. Comparing base (
a40ff3f
) to head (66d6fd9
).:exclamation: Current head 66d6fd9 differs from pull request most recent head fa8b715
Please upload reports for the commit fa8b715 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes: https://github.com/mysociety/societyworks/issues/4219
This commit helps screen reader to notify the user once the number of results in the map have been updated.
Note:
The reason to not add
aria-live="polite"
on thejs-reports-list
that contains messages like 'No reports to show on map, here are some nearby:' is because after testing I realised it also starts reading all the reports found, one by one. So this commit cover cases where:However it doesn't cover the scenario where: "No reports to show on map, here are some nearby:", because that one is nested inside
.js-reports-list
and the text is not dynamic, is basically hidden if the condition is not met, thereforearia-live
doesn't have an effect. As an idea we could add a screen-reader only label, that gets displayed when there are not results, but there are some nearby. This label would be nested inside.js-pagination
and would let the user no "No results found, but there are some nearby reports instead"[Skip changelog]