mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
508 stars 235 forks source link

Prevent hidden missed collection selection if given service is no longer eligible #4986

Closed nephila-nacrea closed 3 months ago

nephila-nacrea commented 4 months ago

Fixes https://github.com/mysociety/societyworks/issues/4342 .

Touches code shared between all cobrands, so presumably fixes the issue across all cobrands. (At the very least, doesn't break existing behaviour - see screengrab below).

https://github.com/mysociety/fixmystreet/assets/11098355/2fc562a9-944f-44d9-b48b-99045c86a7e3

[skip changelog]

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.62%. Comparing base (244931d) to head (9734ff3).

:exclamation: Current head 9734ff3 differs from pull request most recent head 942b803

Please upload reports for the commit 942b803 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4986 +/- ## ========================================== + Coverage 82.59% 82.62% +0.02% ========================================== Files 393 393 Lines 30764 30754 -10 Branches 4880 4877 -3 ========================================== - Hits 25411 25409 -2 + Misses 3901 3894 -7 + Partials 1452 1451 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.