search

mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
508 stars 235 forks source link

Initial notts police setup. #4987

Closed neprune closed 3 months ago

neprune commented 4 months ago

Initial cobrand setup.

Also closes https://github.com/mysociety/societyworks/issues/4340.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.02%. Comparing base (8664dc6) to head (af237d2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## notts-police-reviewed #4987 +/- ## ========================================================== - Coverage 82.60% 69.02% -13.59% ========================================================== Files 393 42 -351 Lines 30752 5085 -25667 Branches 4877 0 -4877 ========================================================== - Hits 25404 3510 -21894 + Misses 3896 1575 -2321 + Partials 1452 0 -1452 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dracos commented 3 months ago

Do we want the parent of the cobrand to be UKCouncils, is that needed as it's a totally standalone cobrand? I imagine there are plus/minus points either way - e.g. see HighwaysEngland/Thamesmead for the functions that had to be copied from UKCouncils (that code suggests a role) so that's awkward, but the parent has unnecessary stuff - e.g. the problem/user restrictions presumably aren't needed, nor all the national highways/munging etc bits that only really apply to cobrands. Just wanted to check this had been considered.