mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
501 stars 235 forks source link

[Bexley] Collected today check should check scheduled collections #4988

Closed chrismytton closed 1 month ago

chrismytton commented 1 month ago

In-cab logs only have a RoundCode, but that can't be matched directly to a collection's RoundSchedule because both weekly and fortnightly collections share a RoundCode in the logs. So we need to do this extra check to ensure we were actually expecting a collection in the past three days.

For https://3.basecamp.com/4020879/buckets/35109031/todos/7468948862

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.61%. Comparing base (72ea05a) to head (6799846).

:exclamation: Current head 6799846 differs from pull request most recent head 616c0e5

Please upload reports for the commit 616c0e5 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4988 +/- ## =========================================== + Coverage 68.98% 82.61% +13.62% =========================================== Files 42 393 +351 Lines 5085 30770 +25685 Branches 0 4881 +4881 =========================================== + Hits 3508 25420 +21912 - Misses 1577 3899 +2322 - Partials 0 1451 +1451 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chrismytton commented 1 month ago

@nephila-nacrea I need to write more tests for this I think, but would be good if you could check the changes I've made look sensible.