Closed chrismytton closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.61%. Comparing base (
72ea05a
) to head (6799846
).:exclamation: Current head 6799846 differs from pull request most recent head 616c0e5
Please upload reports for the commit 616c0e5 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@nephila-nacrea I need to write more tests for this I think, but would be good if you could check the changes I've made look sensible.
In-cab logs only have a RoundCode, but that can't be matched directly to a collection's RoundSchedule because both weekly and fortnightly collections share a RoundCode in the logs. So we need to do this extra check to ensure we were actually expecting a collection in the past three days.
For https://3.basecamp.com/4020879/buckets/35109031/todos/7468948862