Open lucascumsille opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.40%. Comparing base (
8664dc6
) to head (f21d73d
). Report is 45 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@davea I added these changes to every cobrand, so not only for Surrey, thinking that in a future everyone might start adding these tags to the message, but let me know if you prefer me to move it, so it only applies to Surrey
This change looks good in isolation, but before we can merge it I think there's more work to be done on https://github.com/mysociety/fixmystreet/pull/4959 which might necessitate changes if we remove the label
element for notices. For now no need to do anything - I'll check this against that surrey-html-tags-in-notices
branch once I've removed the label
.
@lizettal I'll be including our discussion here in case.
To summarise
All the styling that we applied on .js-post-category-messages
ideally should be also applied to .extra-category-questions
they are both similar components and how it is at the moment is causing some differences in Surrey.
@davea in the meantime I have added a fixup that will apply the same styling to .extra-category-questions
let me know if that could be problematic, and we should drop it. Giving a Quick Look to other cobrands I don't think there will be css clashes.
Fixes: https://github.com/mysociety/societyworks/issues/4308
Added some spacing and sizing fixes for elements inside
.js-post-category-messages
.https://github.com/mysociety/fixmystreet/assets/13790153/136a6c8f-6ad4-46ad-b7c9-abd64a786f06
[Skip changelog]