mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
501 stars 235 forks source link

Added varius stying fixes to .js-post-category-messages element #4989

Open lucascumsille opened 1 month ago

lucascumsille commented 1 month ago

Fixes: https://github.com/mysociety/societyworks/issues/4308

Added some spacing and sizing fixes for elements inside .js-post-category-messages.

Screenshot 2024-06-05 at 11 52 30

https://github.com/mysociety/fixmystreet/assets/13790153/136a6c8f-6ad4-46ad-b7c9-abd64a786f06

[Skip changelog]

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.40%. Comparing base (8664dc6) to head (f21d73d). Report is 45 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4989 +/- ## ========================================== + Coverage 82.60% 83.40% +0.79% ========================================== Files 393 396 +3 Lines 30752 33256 +2504 Branches 4877 5599 +722 ========================================== + Hits 25404 27738 +2334 - Misses 3896 4042 +146 - Partials 1452 1476 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lucascumsille commented 1 month ago

@davea I added these changes to every cobrand, so not only for Surrey, thinking that in a future everyone might start adding these tags to the message, but let me know if you prefer me to move it, so it only applies to Surrey

davea commented 1 month ago

This change looks good in isolation, but before we can merge it I think there's more work to be done on https://github.com/mysociety/fixmystreet/pull/4959 which might necessitate changes if we remove the label element for notices. For now no need to do anything - I'll check this against that surrey-html-tags-in-notices branch once I've removed the label.

lucascumsille commented 1 month ago

@lizettal I'll be including our discussion here in case. To summarise All the styling that we applied on .js-post-category-messages ideally should be also applied to .extra-category-questions they are both similar components and how it is at the moment is causing some differences in Surrey.

Screenshot 2024-06-25 at 12 14 21

@davea in the meantime I have added a fixup that will apply the same styling to .extra-category-questions let me know if that could be problematic, and we should drop it. Giving a Quick Look to other cobrands I don't think there will be css clashes.