mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
501 stars 235 forks source link

[Notts] Added front-end #4996

Closed lucascumsille closed 1 month ago

lucascumsille commented 1 month ago

Fixes: https://github.com/mysociety/societyworks/issues/4256

Desktop

Screenshot 2024-06-10 at 12 07 38 Screenshot 2024-06-10 at 12 07 44 Screenshot 2024-06-10 at 12 08 51 Screenshot 2024-06-10 at 12 09 00

Mobile

Screenshot 2024-06-10 at 12 09 48 Screenshot 2024-06-10 at 12 09 35

Emails

Screenshot 2024-06-10 at 12 06 30 Screenshot 2024-06-10 at 12 06 20

[skip changelog]

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.58%. Comparing base (dca3b3a) to head (e436ad2).

:exclamation: Current head e436ad2 differs from pull request most recent head af237d2

Please upload reports for the commit af237d2 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## notts-police-init #4996 +/- ## ===================================================== + Coverage 82.56% 82.58% +0.01% ===================================================== Files 394 394 Lines 30771 30764 -7 Branches 4878 4877 -1 ===================================================== - Hits 25407 25406 -1 + Misses 3911 3905 -6 Partials 1453 1453 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lucascumsille commented 1 month ago

WPA here: Notts-police-app-icon

lucascumsille commented 1 month ago

Also noticed the button placement looks odd here: Screenshot 2024-06-17 at 11 35 39

Additionally, may not be an issue but the font size seems bigger than on the default FMS site and other cobrands. I often have the sites zoomed to about 80% but it still seemed really 'big' to me.

Unfortunately both of those issues are due to their branding. In their website they use 20px font-size, which is probably the bigger we have ever used. I think they do it for accessibility purposes and help users with vision impairment. Because of that I had to increase the max-width of the default container and the sidebar in the map section. We did the same for Camden and other cobrands where the font-size is bigger than 16px.

Regarding the button, is an issue with probably most cobrands that have an outline with some off-set value.

lucascumsille commented 1 month ago

@nephila-nacrea let me know when you have merged it intonotts-police-reviewed and I'll fix the typos =)

nephila-nacrea commented 1 month ago

@lucascumsille Everything is now on notts-police-reviewed so you can make a branch on top of that for your fixes :-)