Closed lucascumsille closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.58%. Comparing base (
dca3b3a
) to head (e436ad2
).:exclamation: Current head e436ad2 differs from pull request most recent head af237d2
Please upload reports for the commit af237d2 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
WPA here:
Also noticed the button placement looks odd here:
Additionally, may not be an issue but the font size seems bigger than on the default FMS site and other cobrands. I often have the sites zoomed to about 80% but it still seemed really 'big' to me.
Unfortunately both of those issues are due to their branding. In their website they use 20px font-size, which is probably the bigger we have ever used. I think they do it for accessibility purposes and help users with vision impairment. Because of that I had to increase the max-width of the default container and the sidebar in the map section. We did the same for Camden and other cobrands where the font-size is bigger than 16px.
Regarding the button, is an issue with probably most cobrands that have an outline with some off-set value.
@nephila-nacrea let me know when you have merged it intonotts-police-reviewed
and I'll fix the typos =)
@lucascumsille Everything is now on notts-police-reviewed
so you can make a branch on top of that for your fixes :-)
Fixes: https://github.com/mysociety/societyworks/issues/4256
Desktop
Mobile
Emails
[skip changelog]