search

mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
501 stars 232 forks source link

[Kingston] Fix cost when request has collection. #5010

Closed dracos closed 3 weeks ago

dracos commented 3 weeks ago

[skip changelog] FD-4257

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.62%. Comparing base (6f8efe0) to head (773d225).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5010 +/- ## ======================================= Coverage 82.62% 82.62% ======================================= Files 395 395 Lines 30796 30796 Branches 4883 4883 ======================================= Hits 25446 25446 - Misses 3900 3901 +1 + Partials 1450 1449 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dracos commented 3 weeks ago

Note post-live, changed to make sure $c->set_param('payment', $cost) is always set, otherwise it leaks from one report to the next (in test, not spotted as first report is the collection, but if you had one bin delivered and two boxes removed, they'd all inherit the 1800 from the first bin...)