codecov[bot]
commented
1 week ago Codecov Report
Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
Project coverage is 82.57%. Comparing base (
7bcad38) to head (071c731).:exclamation: Current head 071c731 differs from pull request most recent head dc84719
Please upload reports for the commit dc84719 to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| perllib/FixMyStreet/Cobrand/Surrey.pm | 0.00% | 3 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## surrey-cobrand #5036 +/- ## ================================================== - Coverage 82.57% 82.57% -0.01% ================================================== Files 392 392 Lines 30508 30510 +2 Branches 4815 4815 ================================================== + Hits 25193 25194 +1 - Misses 3881 3882 +1 Partials 1434 1434 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes https://github.com/mysociety/societyworks/issues/4370 - don't think I've missed anything, but would be good to check. We should probably have a simpler generic way to do a "use external_id over id" option. Fixes https://github.com/mysociety/societyworks/issues/4409 - this seemed a very simple "fix" so not sure if this will have broken anything! Fixes https://github.com/mysociety/societyworks/issues/4408 - have added the option, not sure I fully understood Dave's point here but hopefully this is enough for whatever he wanted (could also probably have a generic way of doing this as in use in a few places now) Fixes https://github.com/mysociety/societyworks/issues/4391 - hopefully this is just the config from the new feature you added.