search

mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
511 stars 236 forks source link

Email changes for 'no collections' enquiries #5062

Closed nephila-nacrea closed 2 months ago

nephila-nacrea commented 3 months ago

Fixes https://github.com/mysociety/societyworks/issues/4394.

This change includes moving to bespoke templates for Bexley waste, and removing Bexley logic from default templates.

[skip changelog]

Screenshot 2024-07-11 at 14 59 50 Screenshot 2024-07-11 at 15 00 01 Screenshot 2024-07-11 at 15 00 15 Screenshot 2024-07-11 at 15 00 28

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (ade7ba6) to head (fba2cd5).

Files Patch % Lines
perllib/FixMyStreet/SendReport/Email/Bexley.pm 71.42% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5062 +/- ## ========================================== - Coverage 82.71% 82.70% -0.01% ========================================== Files 402 403 +1 Lines 31346 31353 +7 Branches 4970 4971 +1 ========================================== + Hits 25927 25931 +4 - Misses 3947 3949 +2 - Partials 1472 1473 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nephila-nacrea commented 3 months ago

@chrismytton , @jacquelinebylau Important note: When this PR is put on staging and live, the 'Business or organisation missed collection enquiry' and 'Missed collection enquiry' categories will need to have their send methods set to 'Email::Bexley'.