Added $body-font variable to input, select and textarea elements

mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions

http://fixmystreet.org/

Other

506 stars 235 forks source link

Added $body-font variable to input, select and textarea elements #5080

Closed lucascumsille closed 1 month ago

lucascumsille commented 1 month ago

Fixes: https://github.com/mysociety/societyworks/issues/4415

UI Improvement: Currently, FMS and cobrands use the system default. Depending on the font the cobrand and system use, this can feel quite disjointed.

Preview:

[Skip changelog]

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.65%. Comparing base (c683524) to head (453d6d8).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #5080 +/- ## ======================================= Coverage 82.64% 82.65% ======================================= Files 403 403 Lines 31364 31368 +4 Branches 4973 4973 ======================================= + Hits 25922 25926 +4 Misses 3967 3967 Partials 1475 1475 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lucascumsille commented 1 month ago

@dracos Good point, to be fair I haven't deal with many cobrands using the $meta-font, but I'm on board with that. I added an if where basically we use the meta if has been declared. Another alternative would be to do it at the very top, so if no meta has been declared then: meta-font: $body-font

Let me know what you think

lucascumsille commented 1 month ago

@dracos I pushed a fixup, let's use the meta-font is available let's take advantage of it =)