search

mysociety / fixmystreet

This is mySociety's popular map-based reporting platform: easy to install in new countries and regions
http://fixmystreet.org/
Other
513 stars 236 forks source link

Zooming while other pins loading opens a report #5225

Open mattbaker-digital opened 3 hours ago

mattbaker-digital commented 3 hours ago

Describe the bug Pinch zooming in android app on map while only some of the pins have loaded and the loading animation in top left is visible results in a report being opened as though you had tapped on the pin.

To Reproduce Steps to reproduce the behavior:

  1. Open the app and go to the map view
  2. Zoom in until some pins have loaded.
  3. Pinch zoom in further to load more pins.
  4. While loading animation is visible in top left, zoom in more.

Expected behavior Map displays zoomed area with pins loaded and report not opened until tapped on a pin.

Screenshots https://1drv.ms/v/s!Ajr10IwsuvM9hOEooKcvcH20ZlbJrA

Smartphone (please complete the following information):

dracos commented 3 hours ago

Thanks for your report. I have replicated it locally on an iPhone, so it's not Android specific. I don't /think/ it's to do with the pins loading - I think I can have it happen when they are not. The issue appears to be if one (or both?) of the fingers used in the pinch zoom is over a pin when you start (end?) the pinch zoom gesture, the map takes this as a tap of that pin rather than only a pinch zoom. But not always?

Nothing has changed in the map handling code recently, apart from a fix to cancel touch events should you move your finger off the zoom button - which sounds like it could be related, but I don't think it should be? This might be tricky to track down, but hopefully we'll be able to work it out.