Review all text in automated emails

[TomSteinberg]

Will require their help to add in changes from @MyfanwyNixon

[BenJam]

We would like to push forward re-wording the piece in the footer regarding FMS for Councils asap so consider this a ++

[dracos]

If the footer needs rewording, it can be reworded, I don't see a problem with incremental changes :) Not sure what "their help" refers to here, but template changes can be made on github without developer involvement using the process outlined on the wiki, it only needs involvement to be merged and deployed. I'd like to do a new release of the code asap if that helps with this.

[MyfanwyNixon]

I've written suggested text here: https://docs.google.com/document/d/1fp760UdLPZROJNFF0_sjhuD5gWigAeCRY_JBrmBSPwQ/edit#

But I haven't submitted it as a pull request because I'd like comments from @dracos, @TomSteinberg @davewhiteland first.

Also, I've added a few thoughts at the foot of that document:

a) auto-response for when someone reports a problem as abusive (I didn't see one? Do we have one?) b) potential rewording for the homepage, also to try to minimise people who send us reports directly (although as Matthew notes, sorting out the contact form may also help there) c) change to the cross-linking text displayed when someone clicks 'no' on the questionnaire; currently promoting PB as well as WTT

[dracos]

a) No we don't, as it's not by email - they get some sort of generic thanks message in their web browser, and the text there is found at https://github.com/mysociety/fixmystreet/blob/master/templates/web/default/contact/submit.html and probably could not be the same for "contact form submission" and "abuse form submission" as it currently is.

[MyfanwyNixon]

Submitted a pull request. However, the following points are still up for debate:

• Is it possible to format the emails to any degree? Even if they are not fully 'designed', they would benefit from, eg, header titles for sections like 'unsubscribe'; the 'you've tried to respond to an automatic email' message, in particular, has many sections and (if we can't split it into several emails) would also be easier to read with some paragraph headers.
• I haven't updated https://github.com/mysociety/fixmystreet/blob/master/templates/email/fixmystreet/alert-update.txt because ideally I'd like to split it into two (different emails depending on whether the recipient is also the originator of the report).
• I haven't done anything about 'you've submitted a report for abuse' copy, as discussed on the Google doc.
• I haven't solved the use of 'council' in a few of the emails where it might benefit other versions of the site to have a more generic term.
• I have put URLs into the signature for our Twitter & FB accounts when it would be nicer to have links; I'm assuming we can't do that in plain text emails though.
• Oh, I didn't submit my changes to the 'sorry your problem hasn't been fixed' page. What is the etiquette for making a small change after you've submitted a pull request?

[dracos]

"What is the etiquette for making a small change after you've submitted a pull request?" <-- just make a new commit in the branch, it gets added to the pull request if it's still open.

[MyfanwyNixon]

Thanks; done.

[dracos]

"I haven't updated https://github.com/mysociety/fixmystreet/blob/master/templates/email/fixmystreet/alert-update.txt because ideally I'd like to split it into two (different emails depending on whether the recipient is also the originator of the report)." <-- given we don't know when that could or will occur, I don't think you should let that stop you changing the text of this one in a general case. "I haven't solved the use of 'council' in a few of the emails where it might benefit other versions of the site to have a more generic term." <-- it's not just other versions. Some reports on fixmystreet.com are sent to TfL, for example, and these emails don't make sense given that. Just having "confirm that you want to send your report." seems okay for that one, for example. "I have put URLs into the signature for our Twitter & FB accounts when it would be nicer to have links; I'm assuming we can't do that in plain text emails though." <-- if they're links, they'll be linked, so that seems okay.

[dracos]

Ah, sorry, just noticed this - there are two types of emails, those with <?=$values variables and those with [% ... %] variables. These variables can't be mixed, I'm afraid, so e.g. if you've included a [% INCLUDE 'site-name.txt' | trim %] in a template that uses the other style, it won't work. (This is presumably why those files didn't already do that, thinking about it.)

I've left notes about tidying the commits on the pull request.