mysociety / fixmytransport

A site focussed on connecting and empowering people who share transport problems of different kinds.
http://www.mysociety.org/2010/03/15/mysocietys-next-12-months-fixmytransport-and-project-fosbury/
Other
37 stars 10 forks source link

test failures relating to parsing attachments #764

Closed mhl closed 11 years ago

mhl commented 11 years ago

I get the following three test failures (even when checking out very old versions of the code):

1)
Test::Unit::AssertionFailedError in 'FixMyTransport::Email when managing attachments should flatten attachments'
<3> expected but was
<1>.
./spec/lib/fixmytransport/email_spec.rb:77:

2)
Test::Unit::AssertionFailedError in 'FixMyTransport::Email when managing attachments should manage having the same filename twice'
<"Same attachment twice.txt"> expected but was
<"incoming request two same name.email">.
./spec/lib/fixmytransport/email_spec.rb:82:

3)
Test::Unit::AssertionFailedError in 'FixMyTransport::Email when managing attachments should manage custom display names'
<"Same attachment twice.txt"> expected but was
<"custom incoming request two same name.email">.
./spec/lib/fixmytransport/email_spec.rb:92:

This is due to the mahoro gem not being installed (as @crowbot explained to me a long time ago, and I only thought to check for in my notes after quite some time!) - is there any reason not to add this to the Gemfile now, as in dacc655637597962dce1c03b1 ?

crowbot commented 11 years ago

Good catch - can it be inserted in the right place in alphabetical order please ?

mhl commented 11 years ago

Oops, I failed to notice the alphabetical ordering. Fixed and deployed now - I also had to add libmagic-dev to config/packages