search

mysociety / ipvtheme

The Alaveteli theme for Informace pro vsechny (Czech Republic)
http://infoprovsechny.cz
MIT License
3 stars 4 forks source link

Czech alphabet on PublicBody.list #11

Closed adysson closed 10 years ago

adysson commented 10 years ago

Please pull these minor changes into ipvtheme/master.

Thank you

Adam

crowbot commented 10 years ago

Hi Adam,

I've merged 0b79f69 to master. Are you happy for that to be deployed?

For the alphabet, I have an alternative suggestion, which uses a before_filter to assign the alphabet. I think this basically does the same thing as your pull request, but means that we don't have to patch the 'list' method. The more code that we have to patch from core in the theme, the more brittle it becomes. Does my alternative (https://github.com/mysociety/ipvtheme/pull/12) seem OK to you?