mysociety / ipvtheme

The Alaveteli theme for Informace pro vsechny (Czech Republic)
http://infoprovsechny.cz
MIT License
3 stars 4 forks source link

Update theme from new design #27

Closed crowbot closed 7 years ago

crowbot commented 7 years ago

Designs in https://invis.io/2880QJIJH, resources in https://groups.google.com/a/mysociety.org/forum/?hl=en-GB#!topic/alaveteli/wJAp1GPuXcw

garethrees commented 7 years ago

Just as a reminder, some of the changes in https://github.com/mysociety/ipvtheme/pull/24 might be useful here too.

wrightmartin commented 7 years ago

A couple of notes on the designs and what I've implemented

crowbot commented 7 years ago

I don’t want to move search bar and add social links becuase that change is coming in a core alaveteli update shortly - adding it now would mean IPV won’t get the change later

Yep, I think that's OK to explain. Can you screenshot what's coming down the line in core for Richard and co so they can compare?

Changing the display of the requests in the lists (into big green boxes) has loads of knock-on affects because the code is everywhere - and will take a long time to implement and ensure nothing breaks/everything looks okay. For now the requests only look like that on the homepage

Fine to push back on this I think.

wrightmartin commented 7 years ago

Ok, all done in https://github.com/mysociety/ipvtheme/pull/28

Ready to show Richard and his team at your leisure

wrightmartin commented 7 years ago
wrightmartin commented 7 years ago

I've done the above in https://github.com/mysociety/ipvtheme/pull/28, except the following

User profile page: Not happy with how it looks

This is Alaveteli's core user profile page, it's on the roadmap to be improved. I'm not sure we should customise this one and make it miss out on any improvement that core gets.

Browse requests page: The filters don't look like the design

This is part of the core design and functionality - true, it doesn't look the same, but it does behave as expected.

The background white is whiter on the original design

I can't see this - perhaps it's a photoshop vs web browser difference? The white in the web version is the same as far as I can tell

wrightmartin commented 7 years ago

Make a request page: the title isn't part of the form

To do this we'd need to customise the whole 'make a request' form - it would mean it won't get any upgrades from changes coming with pro

garethrees commented 7 years ago

Force login: Would prefer a redirect to login page

We can't really change how this works. We do recommend using the default behaviour of presenting the login/registration form just before sending the request, rather before they start.

Different homepage for logged-in users

This isn't something that Alaveteli supports, so we can't do much about this. We're trialling a "dashboard" page for logged in pro users, which may well end up getting used for all users in the future.

garethrees commented 7 years ago

Done!