search

mysociety / local-intelligence-hub

https://www.localintelligencehub.com
Other
6 stars 2 forks source link

Wrong comparators for "Friends of the Earth local action groups" dataset #495

Open zarino opened 7 months ago

zarino commented 7 months ago

"Friends of the Earth local action groups" dataset (constituency_foe_groups) only has "contains" comparators. Which is a bit odd? Especially when the default value is {}!

Screenshot 2024-03-04 at 11 56 43

Either this should be a numeric comparator, like the "Friends of the Earth activists" dataset (constituency_foe_activists_count) in future constituencies:

Screenshot 2024-03-04 at 11 58 03

Or we should have a separate "Number of…" dataset, with a numeric type rather than JSON data type, like we do for Womens Institute groups (constituency_wi_group_count), for example:

Screenshot 2024-03-04 at 12 02 31

struan commented 6 months ago

This should not have been filterable. I've updated this in the database and there's a fix in #510.

There is a ticket (#490) on adding a JSON comparator but it's not straightforward.