search

mysociety / mapit

A web service to map postcodes to administrative boundaries and more
Other
269 stars 88 forks source link

Use unary_union instead of cascaded_union. #340

Closed torotil closed 5 years ago

torotil commented 5 years ago

cascaded_union was deprecated in Django 1.10 and has been removed in 2.0.

The current Django requirement is >= 1.11.2 which is still fine.

codecov[bot] commented 5 years ago

Codecov Report

Merging #340 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   63.73%   63.73%           
=======================================
  Files          38       38           
  Lines        2184     2184           
=======================================
  Hits         1392     1392           
  Misses        792      792
Impacted Files Coverage Δ
mapit/management/command_utils.py 34.34% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b877820...54aa5d9. Read the comment docs.

dracos commented 5 years ago

Thanks for this! I have also got the doctests in that file to be run by the test suite, whoops, which would have caught this.

codecov[bot] commented 5 years ago

Codecov Report

Merging #340 into master will increase coverage by 1.72%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   63.73%   65.46%   +1.72%     
==========================================
  Files          38       39       +1     
  Lines        2184     2189       +5     
==========================================
+ Hits         1392     1433      +41     
+ Misses        792      756      -36
Impacted Files Coverage Δ
mapit/management/command_utils.py 70.7% <100%> (+36.36%) :arrow_up:
mapit/tests/test_doctests.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b877820...54aa5d9. Read the comment docs.