mysociety / mapit

A web service to map postcodes to administrative boundaries and more
Other
269 stars 88 forks source link

Django 3.2/4 testing, dropping older things #388

Closed dracos closed 1 year ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #388 (c2f7720) into master (6124de8) will increase coverage by 0.10%. The diff coverage is 89.39%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   71.94%   72.04%   +0.10%     
==========================================
  Files          39       40       +1     
  Lines        2310     2347      +37     
==========================================
+ Hits         1662     1691      +29     
- Misses        648      656       +8     
Impacted Files Coverage Δ
mapit/iterables.py 76.19% <ø> (ø)
...it/management/commands/mapit_import_area_unions.py 0.00% <0.00%> (ø)
mapit/djangopatch.py 85.36% <85.36%> (ø)
mapit/management/commands/mapit_import.py 52.45% <100.00%> (-0.47%) :arrow_down:
mapit/middleware/__init__.py 96.29% <100.00%> (-0.14%) :arrow_down:
mapit/models.py 84.33% <100.00%> (-0.19%) :arrow_down:
mapit/shortcuts.py 81.81% <100.00%> (-0.28%) :arrow_down:
mapit/tests/test_admin.py 100.00% <100.00%> (ø)
mapit/tests/test_generation_commands.py 100.00% <100.00%> (ø)
mapit/tests/test_import_commands.py 100.00% <100.00%> (ø)
... and 4 more

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dracos commented 2 years ago

I've taken out d9eefbb21aca1a1c83bc5a8d2da706b5ccc4e514 due to comments on #390, dropped 2.2, added 4.1, and added a monkey patch. Guess this is okay to merge after that, not sure if was waiting for anything in particular?