Closed davea closed 2 years ago
Merging #389 (55c59f2) into master (f668519) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 71.96% 71.96%
=======================================
Files 39 39
Lines 2297 2297
=======================================
Hits 1653 1653
Misses 644 644
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f668519...55c59f2. Read the comment docs.
Note the 2.7 flake8 test broke as the script uses a python 3 only bit of code. I know we're dropping py2 in another PR (soon presumably) so perhaps we could just drop the py2 flake8 in Actions, there's still a py3 run of it.
Oops, yes. The (TIL this was in Python 2.7) and/or f-strings I guess. Should I drop py2 on {}
set literal syntaxmaster
now or leave it until #388 lands?
Might as well drop it now so we don't have the failing test, even if only for a (hopefully) short time :) Looks like I didn't drop six in #388 anyway so more could be done there.
Current data from ONS: https://geoportal.statistics.gov.uk/documents/ons::county-electoral-division-to-county-may-2021-lookup-for-england/about (needs converting to CSV manually, didn't really want to introduce a dependency for parsing XLSX files)