search

mysociety / mapit

A web service to map postcodes to administrative boundaries and more
Other
269 stars 88 forks source link

Do not log our own JSON ViewExceptions. #395

Closed dracos closed 1 year ago

dracos commented 1 year ago

Following on from b5172f6d, make sure JSON error output is also marked as already logged, as we do not want to receive logged errors for ones we are choosing to generate.

codecov[bot] commented 1 year ago

Codecov Report

Merging #395 (984e2d3) into master (e016ce6) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head 984e2d3 differs from pull request most recent head 15c4a51. Consider uploading reports for the commit 15c4a51 to get more accurate results

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   71.92%   71.94%   +0.02%     
==========================================
  Files          39       39              
  Lines        2308     2310       +2     
==========================================
+ Hits         1660     1662       +2     
  Misses        648      648
Impacted Files Coverage Δ
mapit/shortcuts.py 82.08% <100.00%> (+0.55%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dracos commented 1 year ago

No, that's only ever used for successful outputs, any error call to output_json (with a code provided) provides an error dict.