search

mysociety / mysociety-docs-theme

Theme used for e.g. fixmystreet.org
1 stars 0 forks source link

Red, yellow, and blue “attention boxes” #12

Closed zarino closed 9 years ago

zarino commented 9 years ago

Fixes #10.

Also includes a fix for double padding/margin inside attention boxes, and a DRY refactoring of the _variables.scss file, while I was in there adding a new variable.

screen shot 2014-12-15 at 10 56 38

(The classes are, from top to bottom, attention-box info, attention-box helpful-hint, and attention-box warning)

I decided against @davewhiteland’s suggestion of adding icons, since the pages are already quite busy, and I’m not convinced icons will make the boxes any more prominent or easier to parse. But speak up if you feel strongly otherwise.

garethrees commented 9 years ago

Awesome :tada:

davewhiteland commented 9 years ago

@zarino this looks great, thanks and +1

You didn't do icons. But then you didn't do drop-shadows and lens flares either ;-)

zarino commented 9 years ago

Merged! Thanks @garethrees @davewhiteland