search

mysociety / mysociety-docs-theme

Theme used for e.g. fixmystreet.org
1 stars 0 forks source link

Simpler clearfix for .page-wrapper #20

Closed zarino closed 8 years ago

zarino commented 8 years ago

Spotted a weird floating issue on the alaveteli documentation pages while I was implementing the standard mySociety footer for alaveteli.org – and tracked it down to a float: left on .page-wrapper.

As far as I could tell, the float was introduced as a way of clearing the page’s floated children, which is uneccessary when we can use @include clearfix() instead.

It might be that the float was really there for a different reason. @davewhiteland @dracos will probably know best.

dracos commented 8 years ago

Can't think of another reason. The comment above your changed lines I think needs changing as well, because it doesn't look like it is always set to the footer colour (and would that work if not on html/body anyway?).

zarino commented 8 years ago

If I understand the comment correctly…

 /* To avoid floaty footer, make background footer colour */

The author is saying "The footer uses the same background colour as the body ($colour_background) so that, when the window is taller than the body content, it looks like the footer extends all the way to the bottom of the window"

@dracos – is that your understanding too?

dracos commented 8 years ago

The footer uses colour_black, page-wrapper uses colour_background, body uses #fff. So I assume that comment is meant to mean something in the window taller than body content area, but it doesn't work/ apply to the given styling.

zarino commented 8 years ago

Hmm, indeed. Shall I just remove the comment, or fix it so that the body and the footer share a common background-color?

dracos commented 8 years ago

I'd just remove it. Personally, I've never minded about the bottom colour of very short pages, especially if it would mean having a totally different default body background colour as here.

zarino commented 8 years ago

@dracos: Done!