Closed zarino closed 7 years ago
Shouldn't warning be more orange than error/danger? ;)
Yeah – an orange alert for .warning
would also be more consistent with how Bootstrap does it. But I left it as-is because other sites are already using the docs-theme .warning
class and might be expecting it to stay red. @dracos Do you think I should just bite the bullet and change .warning
to orange anyway?
OIC it was warning
before. Well, if it's a reddy orange, I doubt anyone is precious enough to care :) It's used for the box on e.g. http://fixmystreet.org/customising/css/ , I think orange would be fine there too.
Yeah, it actually looks pretty good in orange:
Which would make the full selection:
We needed a
.success
class for attention-boxes in mapit.mysociety.org so I figured we should just add it to the docs theme so other sites can use it too.While I was there, I split the existing red
.warning
style, into a red.error
style and an orange.warning
style. The warning/error distinction is more consistent with how other libraries like bootstrap do their alerts..danger
also added as an alias for.error
, for those with bootstrap muscle memory ;-)