dracos
commented
4 years ago Hi @rossbowen, Thanks very much for looking at this! Sorry for the delay in replying to you. From a brief glance, this looks great and definitely the right direction. A few comments/issues:
- The resultant data has some duplicate people in it, ie. those people who have been both Welsh Parliament members and MPs etc (e.g. Neil Hamilton) - the person ID should be reused in that case;
- The change of
orgsin Popolo - I see there's at least one script,scripts/datadotparl/one-off-sync-lord-partiesthat uses that directly (it probably shouldn't, so happy for that to be improved if it's the only use!); - Separate parties for Wales; our convention is to have Labour/Conservatives/Liberal Democrats all using the same party, even if technically it is a different organisation, as it's not for any practical purpose.
Hopefully I'll be able to get a bit of time to try this out properly soon and then get it merged. In terms of then getting it onto TWFY, I think it should be straightforward, if not trivial. Someone would need to find all the places where a new type of house/person is needed, and add them, plus add a profile page; I think we did put some Wales stubs in in the past (as house "5"). It looks like https://github.com/mysociety/theyworkforyou/commit/237c19994828d4f9f1e8ce8b97cf181bb5b855f2 is the equivalent for the London Assembly, the most recent addition, so hopefully it would end up being very similar to that.
Hi all,
Following from the discussion held here, the mailing list and commits adding the other houses to
persons.json, I think I have managed to get things into shape for the addition of the Senedd.I'm wondering whether I'm headed in the right direction and what the next steps for getting things into TWFY may be.