search

mysociety / parlparse

The scraper/parser that produces data for TheyWorkForYou, PublicWhip, etc
Other
61 stars 22 forks source link

2024 constituencies #173

Closed dracos closed 2 months ago

dracos commented 2 months ago

This removes the duplicate JSON data handling of constituencies, and adds the 2024 constituencies (with MapIt ID, but open to sticking a different ID in, or no idea, we generally go on name).

ajparsons commented 2 months ago

Looks good - I checked the new GSS codes were the right ones and follow the rest of the changes. Makes sense to reduce any duplicate files.

dracos commented 2 months ago

Sorry, I've just added the changes here to have the update script work with DC's current CSV file.

rbairwell commented 1 month ago

Hi,

I've just noticed that the removal of the members/constituencies.json file in this commit ( https://github.com/mysociety/parlparse/commit/f250e3500ed09a71047d361f80a9a1e2ea7cde5d ) has broken the PublicWhip import system. Is there any chance of resurrecting this file?

dracos commented 1 month ago

@rbairwell The same data was in that file and in people.json, so given we had to add 650 new constituencies anyway, I didn't want to add it in two places :) I've opened https://github.com/publicwhip/publicwhip/pull/40 which should hopefully help get you to the new source (even if I'd kept the old file, you'd still have the encoding issue I mention there).